-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass down the EUI classname attribute #184
Comments
As I looked the TitleWidget, I think we do not have to pass down the classname. we can assign the classname to the widget container and let user override it by using cascading in CSS with asterisk *
and css:
|
The other issue with this approach (noticed in autocomplete) is that for complex component that comprises of many sub elements, we cannot customize all of them with one class for the parent component. |
add a new input prop for autocomplete widget that let users define a wrapper class for it and customize the component CSS with using this class. related to #184
Pretty good approach to allow custom styling AND to solve our styling problem. But the problem, as you mentioned, is with complex components such as the EuiComboBox. It uses React Portals for the dropdown menu. So you can't pass custom and scoped styles like There is the
However, this only affects the dropdown menu (search bar), not the dropdown options. This is also a problem in #144 |
Defined some more requirements:
@Pooya-Oladazimi Could you check if this approach works for solving both issues? Can you think of any other requirements? |
Each widget should provide styling options by passing down a classname property (see TitleWidget as an example).
The text was updated successfully, but these errors were encountered: