Skip to content

Commit 0d4ed96

Browse files
authored
feat: fix code coverage not generated for phonenumber.test project and remove old code coverage upload from appveyor (#246)
1 parent 5225c01 commit 0d4ed96

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -205,3 +205,6 @@ testgeocoding.zip
205205

206206
# Performance tests artifacts
207207
csharp/PhoneNumbers.PerformanceTest/BenchmarkDotNet.Artifacts/
208+
209+
# Coverage reports
210+
coverage/

appveyor.yml

+1-4
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,13 @@ branches:
2424
- main
2525
before_build:
2626
- dotnet restore csharp -s https://api.nuget.org/v3/index.json
27-
- choco install opencover.portable
28-
- choco install codecov
2927
- ps: Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"
3028
- ps: Compress-Archive -Path "resources\test\geocoding\*" -DestinationPath "resources\test\testgeocoding.zip"
3129
build_script:
3230
- dotnet pack -c Release csharp\PhoneNumbers
3331
- dotnet pack -c Release csharp\PhoneNumbers.Extensions
3432
test_script:
35-
- OpenCover.Console.exe -register:user -target:dotnet.exe -targetargs:"test csharp\PhoneNumbers.sln" -filter:"+[PhoneNumbers]* -[PhoneNumbers.Test]*" -excludebyattribute:*.CompilerGenerated*^ -oldStyle -returntargetcode
36-
- codecov -f results.xml
33+
- dotnet test csharp/PhoneNumbers.sln --configuration Release --verbosity normal --collect:"XPlat Code Coverage" --results-directory ./coverage
3734
artifacts:
3835
- path: csharp\PhoneNumbers\bin\Release\libphonenumber-csharp.*
3936
- path: csharp\PhoneNumbers.Extensions\bin\Release\libphonenumber-csharp.extensions.*

csharp/PhoneNumbers.Extensions.Test/PhoneNumbers.Extensions.Test.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2222
<PrivateAssets>all</PrivateAssets>
2323
</PackageReference>
24-
<PackageReference Include="coverlet.collector" Version="3.2.0">
24+
<PackageReference Include="coverlet.collector" Version="6.0.0">
2525
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2626
<PrivateAssets>all</PrivateAssets>
2727
</PackageReference>

csharp/PhoneNumbers.Test/PhoneNumbers.Test.csproj

+4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@
2525
<PrivateAssets>all</PrivateAssets>
2626
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2727
</PackageReference>
28+
<PackageReference Include="coverlet.collector" Version="6.0.0">
29+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
30+
<PrivateAssets>all</PrivateAssets>
31+
</PackageReference>
2832
</ItemGroup>
2933

3034
<ItemGroup>

0 commit comments

Comments
 (0)