Merge pull request #288 from twcclegg/snk

Add strong name

Author: twcclegg

.github/workflows/build_and_run_unit_tests_linux.yml

@@ -15,6 +15,9 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 9.x
+      - name: Add snk for strong name signing
+        run: |
+          echo "${{ secrets.KEY_SNK_B64 }}" | base64 --decode > key.snk
       - name: Add zip files required for running tests
         run: |
           (cd resources/geocoding; zip -r ../../resources/geocoding.zip *)

.github/workflows/run_all_tests_and_upload_code_coverage.yml

@@ -16,6 +16,10 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: 9.x
+       - name: Add key.snk for strong name signing
+         run: |
+           echo "${{ secrets.KEY_SNK_B64 }}" | Out-File key.snk.b64
+           certutil -decode key.snk.b64 key.snk
       - name: Add zip files required for running tests
         run: |
           Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"

.github/workflows/run_performance_tests_windows.yml

@@ -12,6 +12,10 @@ jobs:
     timeout-minutes: 20
     steps:
       - uses: actions/checkout@v4
+      - name: Add key.snk for strong name signing
+        run: |
+          echo "${{ secrets.KEY_SNK_B64 }}" | Out-File key.snk.b64
+          certutil -decode key.snk.b64 key.snk
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
         with:

appveyor.yml

@@ -17,12 +17,16 @@ configuration: Release
 environment:
   COVERALLS_REPO_TOKEN:
     secure: vncyomjYijKQKcbLpvs7DFLyNWPjW7tk9KNF/bTV5J/RxOnFydZfsJSsp7SMlvUg
+  KEY_SNK_B64:
+    secure: 4AsBl6Xj6lf78x5EnMNljK0LBxgMuL9CWWDEULg35cv3tJw+xBhOMvyrEsX/ic6gpAZFDk0Oths++CV0wNzwFGGRZqsYcyX5UgQgSYgN2+V/jKwYNWZsafyKyeL9RcSRAkJNv572Dm/nR3AVxg9TSHm4EjTMdLAEZ+BDS8iCnzAcunOgpl2vavrCaQqtP9qAfFUkVLyjvzHzwktEQDyEmJr4sdNLPPg09U+T8C22p2jmQd9sQPGbwZe/ljUbvVYiWY/JfxS7fQQQFgBHSC2Po7IZ3cM4rDmgnmOsRixe1omlV2wwG06Jn3EBsFTgGkQ1AfwxwFgxNZomELRR6N8hHWtnte/SvYR7OD+ZfmdHwRJw3XfmaFgrJ/fhkcjNBRICatVO9kAs9s68A5Jxk0mBH3fCUkl5yvL+ulIXQGzHoBNjILMWDjBwiXJ06qrZzyn5kX/aNIbQt8cP0WEkMYxTvA/+SLL64G6L8Aflx4Sw3LpPq+sADQM1k4xA6ZcziwHCodhJ0d2tqDuKYFmXWf1jNml+jWfFOlGAcDJK592M6Ul3AvbZXRz/CxrKOnQ0WkffxT/79RYWsl3gcpFBmt8eX/Ovsc3ts7AREO3vknXv6fxrwtvQZdRfdV28fGk0rnTu41x/btgBQD9IuqWvnAM2fvyrJ6FMTxVo43u5xwgeakRegovaJkysllslslkhKP/BolPq/nt0OyRwH7QFPUUYZoanT8+kRtxP4BnwZBu/Jr4A4h9W+ryecIVILxt0wZiSQBAS0CYmIdX9f2LZw8A79BydhcrL6EnmNg8JwinTdTLk0q37n4XYehrExm9+x1OqPfErAblSbThHf+ehKaypmPxHdsAP+5HCR7gWdv4E2KuCCkZae3LwjUQhT0r0iMwAfS0nW7MCVo6nUYZtVYxxJB/cvKr/uDzeyezkhOxwOkNP4Nw+NSnZkB1giu0VyoWwKPOHe2Kn+K3ZMWUFNNe5xveY6+SGB6NGU+wYWwqA9eyBmv9YEQl7NNWMVHJtBzp2Q9S/BlShEcv+nB3TqWbPuZE0j6K7qhyVdOw4+HMYZOI=
 pull_requests:
   do_not_increment_build_number: true
 branches:
   only:
     - main
 before_build:
+  - ps: $env:KEY_SNK_B64 | Set-Content -Path "key.snk.b64"
+  - certutil -decode key.snk.b64 key.snk
   - dotnet restore csharp -s https://api.nuget.org/v3/index.json
   - ps: Compress-Archive -Path "resources\geocoding\*" -DestinationPath "resources\geocoding.zip"
   - ps: Compress-Archive -Path "resources\test\geocoding\*" -DestinationPath "resources\test\testgeocoding.zip"

csharp/PhoneNumbers.Extensions.Test/PhoneNumbers.Extensions.Test.csproj

@@ -10,6 +10,12 @@
         <IsPackable>false</IsPackable>
     </PropertyGroup>
 
+    <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
+        <SignAssembly>true</SignAssembly>
+        <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
+        <PublicSign>true</PublicSign>
+    </PropertyGroup>
+
     <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
       <Nullable>enable</Nullable>
     </PropertyGroup>

csharp/PhoneNumbers.Extensions/PhoneNumbers.Extensions.csproj

@@ -27,6 +27,12 @@
         <AnalysisLevel>5</AnalysisLevel>
     </PropertyGroup>
 
+    <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
+        <SignAssembly>true</SignAssembly>
+        <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
+        <PublicSign>true</PublicSign>
+    </PropertyGroup>
+
     <ItemGroup>
         <None Include="..\..\icon.png" Pack="true" PackagePath="" />
     </ItemGroup>

csharp/PhoneNumbers.Test/PhoneNumbers.Test.csproj

@@ -9,6 +9,12 @@
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
+    <PublicSign>true</PublicSign>
+  </PropertyGroup>
+
   <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
     <Nullable>enable</Nullable>
   </PropertyGroup>

csharp/PhoneNumbers/PhoneNumbers.csproj

@@ -29,6 +29,13 @@
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(APPVEYOR_PULL_REQUEST_NUMBER)' == ''">
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>../../key.snk</AssemblyOriginatorKeyFile>
+    <PublicSign>true</PublicSign>
+    <DefineConstants>$(DefineConstants);SIGNED</DefineConstants>
+  </PropertyGroup>
+
   <ItemGroup>
     <EmbeddedResource Include="..\..\resources\*.xml" Exclude="..\..\resources\PhoneNumberMetadataForTesting.xml" />
     <EmbeddedResource Include="..\..\resources\timezones\map_data.txt" LinkBase="timezones" />

csharp/PhoneNumbers/Util.cs

@@ -19,7 +19,11 @@
 using System.Collections.Generic;
 using System.Runtime.CompilerServices;
 
+#if !SIGNED
 [assembly: InternalsVisibleTo("PhoneNumbers.Test")]
+#else
+[assembly: InternalsVisibleTo("PhoneNumbers.Test, PublicKey=0024000004800000940000000602000000240000525341310004000001000100bd3070027f51a9975cac34376755e3629985626c0ccbb41bb057f7d06dd6940dafb35ed0358fd96f24525cde3229cecc6fc9eb3bf582ecb6cf3a837f422d38fe2f5d2d7d0b75a5fe9120c77d3a0d25b9b60060cd715146920d675b6f639bcf9845bcf0f42070caca24be55143958dcc4eaa7e4e2941ecf2fab4ba479aaee8dc2")]
+#endif
 
 namespace PhoneNumbers
 {