Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ublue-builder): ensure that skipped architectures do not fail on CI #184

Merged
merged 2 commits into from
Feb 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/build-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,21 @@ jobs:
mkdir -p containers
MOCK_DIR=./mock
CONTAINERS_DIR=./containers
SOURCES_DIR=.
export CONTAINERS_DIR
$just build ${{ matrix.spec }} -r ${{ matrix.chroot }}-$(arch)
SKIPPED_ARCH=false
if [ -e "$SOURCES_DIR/arch_skipped" ] ; then
SKIPPED_ARCH=true
fi
sudo chown -R $(id -u):$(id -g) $MOCK_DIR
echo "mock_dir=$MOCK_DIR" >> "$GITHUB_OUTPUT"
echo "containers_dir=$CONTAINERS_DIR" >> "$GITHUB_OUTPUT"
sudo chown -R $(id -u):$(id -g) $MOCK_DIR
echo "sources_dir=$SOURCES_DIR" >> "$GITHUB_OUTPUT"
echo "skipped_arch=$SKIPPED_ARCH" >> "$GITHUB_OUTPUT"

- name: Upload to Job Artifacts
if: steps.build_package.outputs.skipped_arch == 'false'
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
with:
name: ${{ matrix.chroot }}-${{ matrix.platform }}-rpms
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ output/
mock/
rpmbuild/
brew-out/
arch_skipped
3 changes: 2 additions & 1 deletion Justfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@ build $spec *MOCK_ARGS:
# Mock also needs to be called unprivileged apparently
CONTAINERS_DIR="${CONTAINERS_DIR:-/var/lib/containers}"
MOCK_DIR="${MOCK_DIRECTORY:-./mock}"
SOURCES_DIR="${SOURCES_DIR:-.}"
sudo podman run --privileged --rm -it \
-v "$CONTAINERS_DIR:/var/lib/containers:z" \
-v "$MOCK_DIR:/var/lib/mock:Z" \
-v .:/tmp/sources:Z \
-v "$SOURCES_DIR:/tmp/sources:Z" \
-w /tmp/sources \
--user "$(id -u):$(id -g)" \
-e PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin,HOME=/tmp \
Expand Down
3 changes: 2 additions & 1 deletion ublue-builder/mock-wrapper
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ OUTDIR="$(mktemp -d)"
SPEC_PATH="$(realpath "$(dirname "$SPEC_FILE")")"
rpkg --path "${SPEC_PATH}" spec --outdir "$OUTDIR"
if ! rpmspec -P "${OUTDIR}"/*.spec | grep "ExclusiveArch:" | grep "$(arch)" ; then
echo "Arch Skipped" && exit 0
echo "Arch Skipped" | tee /tmp/sources/arch_skipped
exit 0
fi
group_end

Expand Down