improve: sanoid should install on minimal if zfs

[johnmmcgee]

We should have sanoid available in minimal, since we already allow for the dependencies to be installed and zfs is an option for use.

[bsherman]

Should sanoid actually be part of minimal or no?

I originally thought, if someone installs ucore-minimal with ZFS they probably want this to be lightweight, thus the minimal, and thus may not want all the perl deps brought in by sanoid.

Of course, I AM happy with sanoid in ucore since it's our more opinionated and featureful version.

[bsherman]

Obviously I'm leaning to "no" here, @johnmmcgee , but you can try to convince me. :-)

[johnmmcgee]

Obviously I'm leaning to "no" here, @johnmmcgee , but you can try to convince me. :-)

I understand your stance that ucore should be the opinionated install, however i feel filesystem snapshots are a key component to the health of a system and therefor some sort of tool would benefit that, in the instance that zfs is installed.

We also already have tailscale, wireguard-tools and tmux on minimal, one could argue that those are includes that a majority of people do not use, yet they are in the minimal install.

[bsherman]

I understand your stance that ucore should be the opinionated install, however i feel filesystem snapshots are a key component to the health of a system and therefor some sort of tool would benefit that, in the instance that zfs is installed.

For the record, @johnmmcgee and I had a chat on the side, but my main point is that in a "ucore-minimal ZFS" image... I think sanoid is too opinionated. I agree snapshots are critical to ZFS usage, but if a ZFS user wants our opinionated sanoid, they should use "ucore w/ ZFS" ... if they really want "ucore minimal" their solution to ZFS snapshots is likely going to be some custom scripting, etc. To be clear, having sanoid installed does not require it's use, but, i think it's just a bit too much for minimal.

We also already have tailscale, wireguard-tools and tmux on minimal

Different types of tools vs an opinionated add on for ZFS, IMHO.

[bsherman]

Sanoid on minimal is too much. We won't be merging this one.

[aenertia]

Why not use xfs on ucore? Snapshots have been supported in xfs for a few years and are as easy as running cp --reflink ( see : https://gist.github.com/braindevices/4d0e0a030c7c6500dd3290714e5c0467 )