Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old config option DOT_OR_USCORE #1211

Open
mkavulich opened this issue Feb 26, 2025 · 0 comments
Open

Deprecate old config option DOT_OR_USCORE #1211

mkavulich opened this issue Feb 26, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@mkavulich
Copy link
Collaborator

Description

The option DOT_OR_USCORE has not been tested for almost a year, due to a change in UFS_UTILS that forces underscores in filenames. Since it is no longer relevant, this option should be deprecated/removed from SRW.

Solution

Remove this option from SRW. If the files in question may have different naming conventions in the future or for some other application, then the whole filename should be configurable, not just some weird switch for punctuation. Especially with the more modern ability to use jinja substitution, there shouldn't be any reason why such a switch is needed.

Requirements**

Remove all references to DOT_OR_USCORE, replace with a literal underscore where appropriate in filenames.

Acceptance Criteria (Definition of Done)

See requirements.

Dependencies (optional)

None known

Alternative Solutions (optional)

Continue to leave this dangling relic in the workflow. Not ideal.

@mkavulich mkavulich added the enhancement New feature or request label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant