Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for error handling to download_warcs() #37

Open
amhanson9 opened this issue May 26, 2023 · 0 comments
Open

Add more unit tests for error handling to download_warcs() #37

amhanson9 opened this issue May 26, 2023 · 0 comments

Comments

@amhanson9
Copy link
Contributor

amhanson9 commented May 26, 2023

The function catches errors raised by three other functions: API error for getting the WARC metadata, API error for downloading the WARC, and fixity change after download. 2/3 functions raise two different error types. They all use the same code pattern to handle the raised error.

Currently, the only error handling test is for API error for getting the WARC metadata (input is a WARC name that is not in Archive-It). Add tests for the rest if possible. I'm not sure how to cause them to happen mid-function though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant