Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit testing for seed_data() #39

Open
amhanson9 opened this issue May 26, 2023 · 1 comment
Open

Improve unit testing for seed_data() #39

amhanson9 opened this issue May 26, 2023 · 1 comment

Comments

@amhanson9
Copy link
Contributor

Split into more functions and create tests for each function. Include tests for the CSV contents and not just the dataframe. Wait to do this until switch to CSV input for warc_download.py, since it will require a rework of this function.

@amhanson9
Copy link
Contributor Author

amhanson9 commented Nov 10, 2023

Instead of having one unit test per department, do one unit test per data variation. All the variations appear to be covered by the date ranges chosen, but it isn't explicit what is being tested by each. Variations:

  • Archive-It collection once
  • Archive-It collection more than once
  • Job once
  • Job more than once
  • Seed with one WARC
  • Seed with multiple WARCs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant