Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale_supervised.py uncomment line 181? #4

Open
patschw opened this issue Nov 17, 2024 · 2 comments
Open

scale_supervised.py uncomment line 181? #4

patschw opened this issue Nov 17, 2024 · 2 comments

Comments

@patschw
Copy link

patschw commented Nov 17, 2024

Hi,
I'm playing around with your supervised scaler.

Could it be for it to work one needs to uncomment line 181 because that would set the two pivot text?

As I now understand it the algorithm chooses the most dissimilar texts also in the nlp.scale_supervised just as is also done in nlp.scale.

Or am I misunderstanding the code?

Best,

Patrick

@patschw
Copy link
Author

patschw commented Nov 17, 2024

Got it, line 178 only compares the two pivot texts :) Sorry for the unnecessary ticket!

@fedenanni
Copy link
Collaborator

No worries and all the best with your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants