Skip to content

Commit

Permalink
fix: change hydrateFromRoot root to renderFromRoot
Browse files Browse the repository at this point in the history
  • Loading branch information
Jinbao1001 committed Apr 1, 2024
1 parent 90aebf4 commit 20c4472
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion examples/ssr-demo/.umirc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
scripts: [`https://a.com/b.js`],
ssr: {
builder: 'webpack',
hydrateFromRoot: false,
renderFromRoot: false,
},
styles: [`body { color: red; }`, `https://a.com/b.css`],

Expand Down
2 changes: 1 addition & 1 deletion packages/preset-umi/src/features/ssr/ssr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export default (api: IApi) => {
serverBuildPath: zod.string(),
platform: zod.string(),
builder: zod.enum(['esbuild', 'webpack']),
hydrateFromRoot: zod.boolean(),
renderFromRoot: zod.boolean(),
})
.deepPartial();
},
Expand Down
2 changes: 1 addition & 1 deletion packages/preset-umi/src/features/tmpFiles/tmpFiles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ if (process.env.NODE_ENV === 'development') {
metas,
scripts: scripts || [],
}),
hydrateFromRoot: api.config.ssr?.hydrateFromRoot ?? false,
renderFromRoot: api.config.ssr?.renderFromRoot ?? false,
},
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/preset-umi/templates/server.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const createOpts = {
createHistory,
ServerInsertedHTMLContext,
metadata: {{{metadata}}},
hydrateFromRoot: {{{hydrateFromRoot}}}
renderFromRoot: {{{renderFromRoot}}}

};
const requestHandler = createRequestHandler(createOpts);
Expand Down
6 changes: 3 additions & 3 deletions packages/renderer-react/src/browser.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ export type RenderClientOpts = {
*/
rootElement?: HTMLElement;
/**
* ssr 是否从 app root 根节点开始 hydrate
* @doc 默认 false, 从 app root 开始水合,为 true 时从 html 开始
* ssr 是否从 app root 根节点开始 render
* @doc 默认 false, 从 app root 开始 render,为 true 时从 html 开始
*/
hydrateFromRoot?: boolean;
renderFromRoot?: boolean;
/**
* 当前的路由配置
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/renderer-react/src/server.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export async function getClientRootComponent(opts: IRootComponentOptions) {
{rootContainer}
</AppContext.Provider>
);
if (!opts.hydrateFromRoot) {
if (!opts.renderFromRoot) {
return <Html {...opts}>{app}</Html>;
} else {
return app;
Expand Down
2 changes: 1 addition & 1 deletion packages/renderer-react/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export interface IRootComponentOptions {
loaderData: { [routeKey: string]: any };
manifest: any;
metadata?: IMetadata;
hydrateFromRoot: boolean;
renderFromRoot: boolean;
}

export interface IHtmlProps {
Expand Down
4 changes: 2 additions & 2 deletions packages/server/src/ssr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ interface CreateRequestHandlerOptions extends CreateRequestServerlessOptions {
helmetContext?: any;
ServerInsertedHTMLContext: React.Context<ServerInsertedHTMLHook | null>;
metadata: IMetadata;
hydrateFromRoot: boolean;
renderFromRoot: boolean;
}

interface IExecLoaderOpts {
Expand Down Expand Up @@ -157,7 +157,7 @@ function createJSXGenerator(opts: CreateRequestHandlerOptions) {
manifest,
loaderData,
metadata: opts.metadata,
hydrateFromRoot: opts.hydrateFromRoot,
renderFromRoot: opts.renderFromRoot,
};

const element = (await opts.getClientRootComponent(
Expand Down

0 comments on commit 20c4472

Please sign in to comment.