refactor: rename config

umijs · Apr 7, 2024 · 7a56401 · 7a56401
1 parent 0c2fc10
commit 7a56401
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/preset-umi/src/features/ssr/ssr.ts b/packages/preset-umi/src/features/ssr/ssr.ts
@@ -25,7 +25,7 @@ export default (api: IApi) => {
         return zod
           .object({
             serverBuildPath: zod.string(),
-            serverBuildMode: zod.enum(['express', 'worker']),
+            serverBuildTarget: zod.enum(['express', 'worker']),
             platform: zod.string(),
             builder: zod.enum(['esbuild', 'webpack']),
             renderFromRoot: zod.boolean(),
@@ -51,11 +51,12 @@ export default (api: IApi) => {
   });
 
   api.modifyConfig((memo) => {
-    // define SSR_BUILD_MODE to strip useless logic
+    // define SSR_BUILD_TARGET to strip useless logic
     memo.define ??= {};
-    memo.define.SSR_BUILD_MODE = api.config.ssr.serverBuildMode || 'express';
+    memo.define.SSR_BUILD_TARGET =
+      api.config.ssr.serverBuildTarget || 'express';
 
-    if (api.config.serverBuildMode === 'worker') {
+    if (api.config.serverBuildTarget === 'worker') {
       // use browser version of react-dom/server for worker mode
       // ref: https://github.com/facebook/react/blob/f86afca090b668d8be10b642750844759768d1ad/packages/react-server-dom-webpack/package.json#L52
       memo.alias['react-dom/server$'] = winPath(

diff --git a/packages/server/src/ssr.ts b/packages/server/src/ssr.ts
@@ -288,7 +288,7 @@ export default function createRequestHandler(
 
     const replaceServerHTMLScript = `<script>!function(){var e=document.getElementById("${SERVER_INSERTED_HTML}");e&&(Array.from(e.children).forEach(e=>{document.head.appendChild(e)}),e.remove())}();</script>`;
 
-    if (process.env.SSR_BUILD_MODE === 'worker') {
+    if (process.env.SSR_BUILD_TARGET === 'worker') {
       // worker mode
       const [ev, workerOpts] = args as IWorkerRequestHandlerArgs;
       const { pathname, searchParams } = new URL(ev.request.url);