tsチェック導入

Author: k1tikurisu

.yarn/install-state.gz

@@ -45,10 +45,11 @@ export function fetchCalendarChanges(
 function fetchSyncToken(calendarId: string) {
   const now = new Date();
   let pageToken: string | undefined = undefined;
+  let res: GoogleAppsScript.Calendar.Schema.Events | undefined = undefined;
 
   // 現在時刻以降のイベントを取得し続ける
   while (true) {
-    const res = Calendar.Events?.list(calendarId, {
+    res = Calendar.Events?.list(calendarId, {
       calendarId,
       pageToken,
       showDeleted: true,
@@ -57,8 +58,8 @@ function fetchSyncToken(calendarId: string) {
     });
 
     // syncToken が得られたら終了する
-    if (res.nextSyncToken) return res.nextSyncToken;
-    if (!res.nextPageToken) throw new Error();
+    if (res?.nextSyncToken) return res.nextSyncToken;
+    if (!res?.nextPageToken) throw new Error();
     pageToken = res.nextPageToken;
   }
 }

google-calendar/src/functions/fetchCalendarChanges.ts

@@ -80,12 +80,12 @@ function formatDate(date: Date, format: string) {
     mm: pad(date.getMinutes()),
     ss: pad(date.getSeconds()),
     SSS: pad(date.getMilliseconds(), 3),
-    A: "日月火水木金土"[date.getDay()],
+    A: "日月火水木金土"[date.getDay()] || "日",
   };
 
   // フォーマット文字列の置換
   return Object.keys(replacements).reduce(
-    (acc, key) => acc.replace(new RegExp(key, "g"), replacements[key]),
+    (acc, key) => acc.replace(new RegExp(key, "g"), replacements[key] ?? ""),
     format,
   );
 }

google-calendar/src/main.ts

@@ -6,10 +6,12 @@
     "lint": "biome check .",
     "lint:fix": "biome check --apply-unsafe .",
     "format": "biome format --write .",
-    "ci": "biome ci ."
+    "type-check": "tsc --pretty --noEmit",
+    "ci": "biome ci . && yarn type-check"
   },
   "devDependencies": {
-    "@biomejs/biome": "1.5.3"
+    "@biomejs/biome": "1.5.3",
+    "typescript": "5.3.3"
   },
   "workspaces": [
     "triplate-contact-form",

package.json

@@ -10,22 +10,20 @@ function main(e: GoogleAppsScript.Events.FormsOnFormSubmit) {
   const formResponses = e.response.getItemResponses();
   const email = e.response.getRespondentEmail();
 
-  let contents = "";
-  // 項目を繰り返す
-  for (let i = 0; i < formResponses.length; i++) {
-    const formResponse = formResponses[i];
-
-    try {
-      const question = formResponse.getItem().getTitle();
-      const answer = formResponse.getResponse();
-
-      contents += `${question}: ${answer}`;
-    } catch (e) {
-      console.log(e);
-    }
-
-    if (i + 1 !== formResponses.length) contents += "\n";
-  }
+  const contents = formResponses
+    .map((formResponse) => {
+      try {
+        const question = formResponse.getItem().getTitle();
+        const answer = formResponse.getResponse();
+
+        return `${question}: ${answer}`;
+      } catch (error) {
+        console.log(error);
+        return "";
+      }
+    })
+    .filter((line) => line)
+    .join("\n");
 
   const message = `${email}からお問い合わせです。\n\`\`\`\n${contents}\n\`\`\``;
 

triplate-contact-form/src/main.ts

@@ -7,24 +7,22 @@ declare const global: Record<
 global.main = main;
 
 function main(e: GoogleAppsScript.Events.FormsOnFormSubmit) {
-  const formResponses = e.response.getItemResponses();
-
-  let contents = "";
-  // 項目を繰り返す
-  for (let i = 0; i < formResponses.length; i++) {
-    const formResponse = formResponses[i];
-
-    try {
-      const question = formResponse.getItem().getTitle();
-      const answer = formResponse.getResponse();
-
-      contents += `${question}: ${answer}`;
-    } catch (e) {
-      console.log(e);
-    }
-
-    if (i + 1 !== formResponses.length) contents += "\n";
-  }
+  const formResponses = e.response.getItemResponses().filter((e) => e);
+
+  const contents = formResponses
+    .map((formResponse) => {
+      try {
+        const question = formResponse.getItem().getTitle();
+        const answer = formResponse.getResponse();
+
+        return `${question}: ${answer}`;
+      } catch (error) {
+        console.log(error);
+        return "";
+      }
+    })
+    .filter((line) => line)
+    .join("\n");
 
   const message = `アカウント削除申請が届きました。\n\`\`\`\n${contents}\n\`\`\``;
 

triplate-delete-user-form/src/main.ts

@@ -0,0 +1,22 @@
+{
+  "compilerOptions": {
+    "module": "ESNext",
+    "target": "ESNext",
+    "strict": true,
+    "strictNullChecks": true,
+    "strictPropertyInitialization": true,
+    "allowSyntheticDefaultImports": true,
+    "experimentalDecorators": true,
+    "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
+    "declaration": true,
+    "importHelpers": true,
+    "skipLibCheck": true,
+    "moduleResolution": "node",
+    "esModuleInterop": true,
+    "rootDir": "./",
+    "outDir": "./dist",
+  },
+  "include": ["**/*.ts"],
+  "exclude": ["node_modules"]
+}

tsconfig.json

@@ -3749,6 +3749,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"typescript@npm:5.3.3":
+  version: 5.3.3
+  resolution: "typescript@npm:5.3.3"
+  bin:
+    tsc: bin/tsc
+    tsserver: bin/tsserver
+  checksum: 10c0/e33cef99d82573624fc0f854a2980322714986bc35b9cb4d1ce736ed182aeab78e2cb32b385efa493b2a976ef52c53e20d6c6918312353a91850e2b76f1ea44f
+  languageName: node
+  linkType: hard
+
 "typescript@npm:^4.4.2":
   version: 4.9.5
   resolution: "typescript@npm:4.9.5"
@@ -3759,6 +3769,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"typescript@patch:typescript@npm%3A5.3.3#optional!builtin<compat/typescript>":
+  version: 5.3.3
+  resolution: "typescript@patch:typescript@npm%3A5.3.3#optional!builtin<compat/typescript>::version=5.3.3&hash=e012d7"
+  bin:
+    tsc: bin/tsc
+    tsserver: bin/tsserver
+  checksum: 10c0/1d0a5f4ce496c42caa9a30e659c467c5686eae15d54b027ee7866744952547f1be1262f2d40de911618c242b510029d51d43ff605dba8fb740ec85ca2d3f9500
+  languageName: node
+  linkType: hard
+
 "typescript@patch:typescript@npm%3A^4.4.2#optional!builtin<compat/typescript>":
   version: 4.9.5
   resolution: "typescript@patch:typescript@npm%3A4.9.5#optional!builtin<compat/typescript>::version=4.9.5&hash=289587"
@@ -3817,6 +3837,7 @@ __metadata:
   resolution: "uplim-integrations@workspace:."
   dependencies:
     "@biomejs/biome": "npm:1.5.3"
+    typescript: "npm:5.3.3"
   languageName: unknown
   linkType: soft