test_tag_sort fails sometimes

[keithmanville]

The test_tag_sort is inconsistent and fails some times.

I suspect it may fail when no sort criteria is provided and we can't expect a specific order ( the (None, None, ["tag1", "tag2", "tag3"]) case below).

    @pytest.mark.parametrize(
        "sort_by, descending , expected",
        [
            (None, None, ["tag1", "tag2", "tag3"]),
            ("name", True, ["tag2", "tag1", "tag3"]),
            ("name", False, ["tag3", "tag1", "tag2"]),
            ("createdOn", True, ["tag3", "tag2", "tag1"]),
            ("createdOn", False, ["tag1", "tag2", "tag3"]),
        ],
    )
    def test_tag_sort(
    ...

I think Andy encountered something similar here with the returned order of Queues:

dioptra/tests/unit/restapi/v1/test_queue.py

Line 158 in f5f3558

# A sort order was not given in the request, so we must not assume a

Since we don't have a guarantee on the returned order, the test should only check that the correct tags are present and not assume an order.

Currently known tests that check based on order but don't specify one are: Queue Retrieval, Queue Sort (with None, None for sort field and order) and Tags Sort (with None None for sort and order). As part of this issue, check tests the look based on sort_by and do not provide a field and any tests that perform retrieval and check based on a python lists instead of a set.