Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX when server is unresponsive #73

Open
embeddedt opened this issue Oct 10, 2022 · 9 comments
Open

Better UX when server is unresponsive #73

embeddedt opened this issue Oct 10, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request frontend This is related to client

Comments

@embeddedt
Copy link

Describe the bug

Currently, the selected vote only changes on the frontend once the server has acknowledged the vote. This leads to bad UX if the server is slow.

Expected behavior

Ideally, there should be some sort of visual indication that the vote is being sent to the server, and if no acknowledgement is received after 10 seconds or so, an error should be displayed.

Additional context

This is particularly relevant until we are able to sort out the ongoing server load issues.

@huonggiangbui
Copy link
Member

In case you want to work on this, feel free to assign yourself. If not, we will wait for someone interested to comment and we can assign the issue to them : )

@embeddedt
Copy link
Author

In case you want to work on this, feel free to assign yourself.

Hmm, I don't think users can assign themselves to issues unless they're added as collaborators on a repository.

I would be willing to work on it later but at the moment I am looking into #68, could you assign me to that please?

@huonggiangbui
Copy link
Member

sure, got it! if you want to work on any issue, just leave a comment and we will assign it to you!

@huonggiangbui
Copy link
Member

I would be willing to work on it later but at the moment I am looking into #68, could you assign me to that please?

can you leave a comment there so I can assign it to you?

@ggggg
Copy link
Collaborator

ggggg commented Oct 10, 2022

Would this behaviour solve this issue:
User clicks new vote -> overlay with a spinning wheel animation appears until the server responds -> if it errors just show an alert('Vote not received, please try again') message

@huonggiangbui
Copy link
Member

that's correct ! maybe you can do a Alert/Snackbar with library for better UI : ) something like this https://mui.com/material-ui/react-snackbar/

@ggggg
Copy link
Collaborator

ggggg commented Oct 10, 2022

Alrighty, can you assign this issue to me?

@huonggiangbui
Copy link
Member

Done! Good luck !! Feel free to ping us if you have any questions or want to discuss anything!

ggggg added a commit to ggggg/PollVotingSystem that referenced this issue Oct 10, 2022
@ggggg ggggg mentioned this issue Oct 10, 2022
11 tasks
@hiimchrislim
Copy link
Member

One thing to also note is, we also added in an additional feature to prevent students from spamming votes all the time. If you have more questions about it @shubhbapna can probably talk more about this

@logonoff logonoff added enhancement New feature or request frontend This is related to client labels Oct 29, 2022
huonggiangbui added a commit that referenced this issue Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend This is related to client
Projects
None yet
Development

No branches or pull requests

5 participants