fix infinite loop in mux dispatch

DarienRaymond · DarienRaymond · commit db6d6a89df7e · 2018-11-04T08:59:34.000+01:00
diff --git a/common/mux/client.go b/common/mux/client.go
@@ -25,7 +25,7 @@ type ClientManager struct {
 }
 
 func (m *ClientManager) Dispatch(ctx context.Context, link *transport.Link) error {
-	for {
+	for i := 0; i < 16; i++ {
 		worker, err := m.Picker.PickAvailable()
 		if err != nil {
 			return err
@@ -34,6 +34,8 @@ func (m *ClientManager) Dispatch(ctx context.Context, link *transport.Link) erro
 			return nil
 		}
 	}
+
+	return newError("unable to find an available mux client")
 }
 
 type WorkerPicker interface {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ type ClientManager struct {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`func (m ClientManager) Dispatch(ctx context.Context, link transport.Link) error {`
`28`		`- for {`
	`28`	`+ for i := 0; i < 16; i++ {`
`29`	`29`	`worker, err := m.Picker.PickAvailable()`
`30`	`30`	`if err != nil {`
`31`	`31`	`return err`
`@@ -34,6 +34,8 @@ func (m ClientManager) Dispatch(ctx context.Context, link transport.Link) erro`
`34`	`34`	`return nil`
`35`	`35`	`}`
`36`	`36`	`}`
	`37`	`+`
	`38`	`+ return newError("unable to find an available mux client")`
`37`	`39`	`}`
`38`	`40`
`39`	`41`	`type WorkerPicker interface {`