Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cookie Manager removes Add-On Icons from Statusbar #115

Open
gkmasta opened this issue Aug 25, 2016 · 7 comments
Open

[Bug] Cookie Manager removes Add-On Icons from Statusbar #115

gkmasta opened this issue Aug 25, 2016 · 7 comments

Comments

@gkmasta
Copy link

gkmasta commented Aug 25, 2016

Hello,
after my Firefox browser updated automatically to 48.0.1, there seems to be a bug when enabling Cookie Manager+.

If enabled, icons such as "Video DownloadHelper" disappear and don't even show in Firefox's customisation window.
with cookie manager

If disabled, all icons are back again.
without cookie manager

This did not happen in all previous versions of Firefox.

Thanks for your answer.

@gkmasta gkmasta changed the title Cookie Manager removes Add-On Icons from Statusbar [Bug] Cookie Manager removes Add-On Icons from Statusbar Aug 25, 2016
@gkmasta gkmasta changed the title [Bug] Cookie Manager removes Add-On Icons from Statusbar [Bug] Cookie Manager removes Add-On Icons from Statusbar label:bug Aug 25, 2016
@gkmasta gkmasta changed the title [Bug] Cookie Manager removes Add-On Icons from Statusbar label:bug [Bug] Cookie Manager removes Add-On Icons from Statusbar Aug 25, 2016
@vanowm
Copy link
Owner

vanowm commented Aug 25, 2016

That is a strange issue. CM+ uses standard overlay method to add it's buttons and menus to the browser, shouldn't conflict with others. Is video downloadhelper restartless addon?
Is there any errors in browser console?

P.S. can't test it myself for next 12 hours

@gkmasta
Copy link
Author

gkmasta commented Aug 25, 2016

Yes, Video Downloadhelper doesn't require a restart of firefox.

I experienced, that if i enable CM+ with firefox open, I can use it and the other plugin's icons show.
However, if I restart Firefox, the icons are gone.

@gkmasta
Copy link
Author

gkmasta commented Aug 26, 2016

If you mean the Firefox Console, which can be opened with CTRL + Shift + K, then it doesn't show any errors under the "Console" Tab when enabling your addon or restarting firefox which leads to the icons being gone.

@vanowm
Copy link
Owner

vanowm commented Aug 26, 2016

No, I mean CTRL+SHIFT + J

@gkmasta
Copy link
Author

gkmasta commented Aug 26, 2016

So I looked a little more and found out, that when I open Firefox with no saved tabs, all add-ons including CM+ seem to be working flawlessly.
I then opened up one tab by one, and restarted FF after each one until it stopped working.

If I start FF with 3 Tabs saved, everything works.
If I start FF with 4 Tabs saved, the icons are gone.
If I start FF with 4 Tabs saved, and CM+ disabled, everything works.
(the tabs are no specific websites. They can also be about:config, or other firefox pages)

The Console gave this as an error code:

`Warning: NetUtil.asyncFetch() requires the channel to have one of the security flags set in the loadinfo (see nsILoadInfo). Please create channel using NetUtil.newChannel()
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Fri Aug 26 2016 14:45:35 GMT+0200
Full Message: TypeError: access to strict mode caller function is censored
Full Stack: NS_ASSERT@resource://gre/modules/debug.js:50:7
restoreTab@resource:///modules/sessionstore/SessionStore.jsm:3177:5
restoreTabs@resource:///modules/sessionstore/SessionStore.jsm:3171:7
ssi_restoreWindow@resource:///modules/sessionstore/SessionStore.jsm:3035:7
ssi_restoreWindows@resource:///modules/sessionstore/SessionStore.jsm:3114:5
initializeWindow@resource:///modules/sessionstore/SessionStore.jsm:1038:11
SessionStoreInternal.onBeforeBrowserWindowShown/<@resource:///modules/sessionstore/SessionStore.jsm:1193:9
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:750:11
exports.Utils.yield@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/utils.js:361:12
INIParser.prototype.process@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterStorage.js:798:7
exports.IO.readFromFile/onProgress@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:97:15
exports.IO.readFromFile/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///C:/Users/USERNAME/AppData/Roaming/Mozilla/Firefox/Profiles/f76w92cf.default/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:182:11
TaskImpl_run@resource://gre/modules/Task.jsm:319:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:750:11
debug.js:50
Warning: NetUtil.asyncFetch() requires the channel to have one of the security flags set in the loadinfo (see nsILoadInfo). Please create channel using NetUtil.newChannel()
The object cannot be linked to the inspector without a toolbox
console-output.js:3266
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:974:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:973:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:975:8
Warning: NetUtil.asyncFetch() requires the channel to have one of the security flags set in the loadinfo (see nsILoadInfo). Please create channel using NetUtil.newChannel()
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:974:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:973:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:975:8
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/min:7:25381
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:974:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:973:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:975:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:974:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:973:8
unreachable code after return statement[Learn More]RemoteAddonsParent.jsm:975:8`

@vanowm
Copy link
Owner

vanowm commented Aug 26, 2016

The messages you showed have no reference to CM+.
The first message (NetUtil.asyncFetch) is probably related to video downloadhelper, cause I get a full console of that message on browser startup, in fact I get so many of them that it pushes first messages out, because of console limit.
The second big message is related to adblock ( addon ID {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} )

On my end I'm not able reproduce this issue, following your notes I have several tabs restored after restart, both CM+ and VDH enabled, toolbar buttons for both extensions shown just fine, VDH icon however appears with 1sec delay after browser is loaded, but that's probably a side effect of being restartless vs old overlay as CM+.

You could try enable debug in CM+ options and perhaps it might add some addtional information to the matter, but I doubt it.

Without not being able reproduce the issue on my end I can't help much other then suggest you disable all other addons, leave CM+ and VDH enabled, see if the issue persists, if not, start enabling other addons (you'll have to restart restart browser after each addon) maybe that way you could find the combination for me to work with.

Good luck.

@Atavic
Copy link

Atavic commented Feb 24, 2017

It's Firefox update process that creates such issues. Not any specific addon, as CM+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants