Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental sell protection #97

Open
veechs opened this issue Feb 23, 2025 · 1 comment
Open

Accidental sell protection #97

veechs opened this issue Feb 23, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request pending release Available on a development branch

Comments

@veechs
Copy link
Owner

veechs commented Feb 23, 2025

Discussed in #92

Originally posted by selax1 February 20, 2025

What will your feature request solve?

Not sure it's anything to do with the Bagshui addon, but three times now since I've been using it I've accidentally sold valuable items without realizing it until later. Might be a fluke, but this never happened before using the addon. GM's had to restore the items (but lost my enchants). Not sure if it's possible, but would be great if you could mark your valuable gear as "saved" or something so that it would ask for confirmation before you can sell it.

Describe the solution you'd like

Enter edit mode and mark items you want to protect (maybe with an alt+shift click or something else that isn't currently used by the addon). Then these items wouldn't be able to be sold without a confirmation dialog (like a "are you sure you want to sell this?" message box).

Describe alternatives you've considered

alternatively maybe just one button you can toggle on and off to force a sell confirmation dialog on all items? (or maybe on anything over rare item quality) Then if you want to sell anything without a confirmation, you have to toggle the switch off maybe?

Additional context

No response

@veechs veechs added the enhancement New feature or request label Feb 23, 2025
@veechs veechs self-assigned this Feb 23, 2025
veechs added a commit that referenced this issue Feb 23, 2025
Certain items will now require a Control+Right-Click after the initial Right-Click at the vendor to confirm sale. By default, protects items that are:
- Active quest
- Soulbound
- Epic quality or greater
Configurable in Settings > Advanced > Selling Protection.
Closes #97.
@veechs
Copy link
Owner Author

veechs commented Feb 24, 2025

@selax1 - Selling protection is now available on the dev branch if you'd like to try it out. I recommend backing up your WTF\Account[Username]\SavedVariables\Bagshui.lua file first since there are some significant upcoming changes and it would be best to restore the backup if you decide to go back to main.

@veechs veechs linked a pull request Feb 24, 2025 that will close this issue
@veechs veechs removed a link to a pull request Feb 24, 2025
@veechs veechs added the pending release Available on a development branch label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending release Available on a development branch
Projects
None yet
Development

No branches or pull requests

1 participant