New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DID creation infinite loop if only 2 nodes on the network #376

Open

tahpot opened this issue Dec 17, 2023 · 1 comment · Fixed by #377

Assignees

Labels

bug

Member

tahpot commented Dec 17, 2023

If there are only two nodes available on the network, the minimum threshold of 3 is never met for storing a DID document.

This results in an infinite loop that needs to be caught and an error thrown.

tahpot added the bug label

tahpot self-assigned this

Member Author

tahpot commented Dec 18, 2023

There were several factors going on here.

The mainnet.json file had incorrect entries causing intermittent issues
vda-did didn't have a limit to the number of retries it attempts when trying to create a DID, causing an infinite loop in some scenarios
A bug in the node selector of account-node which caused duplicate nodes to be selected in some scenarios

tahpot mentioned this issue

Fix/376 node loop issue #377

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment