Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VGS Alias formats from StarLarky #186

Open
fshaikh-vgs opened this issue Oct 11, 2021 · 3 comments
Open

Remove VGS Alias formats from StarLarky #186

fshaikh-vgs opened this issue Oct 11, 2021 · 3 comments
Labels
question Further information is requested triaged

Comments

@fshaikh-vgs
Copy link

fshaikh-vgs commented Oct 11, 2021

ea0adcf#diff-cf5faff91ae9cd74b7b9d2504673969166da7d94e0b519c53f7b0dfaa2fd856f

This seems like a misplaced validation. The StarLarky repo should not care about the names of VGS alias formats. It should just have an interface that handles exceptions in case the runtime determines that the alias format is not supported.

Having to update StarLarky every time a new Alias format is created does not seem like an appropriate workflow.

@mahmoudimus
Copy link
Contributor

Are you planning on exposing to customers the alias formats via Larky? If so, can it be an enum that you can override by passing in a string until larky is updated?

@mahmoudimus
Copy link
Contributor

Is this issue asking to remove the validation or asking to remove alias format lists from Larky all together?

@mahmoudimus mahmoudimus added the question Further information is requested label Oct 12, 2021
@fshaikh-vgs
Copy link
Author

fshaikh-vgs commented Oct 12, 2021

The ask is to remove the list of alias formats from Larky completely. I do not want to update VaultModule.java in the StarLarky repo when we release new alias formats.

Larky will get a response from the Vault (or some other service that is responsible for responding to the vault module) if the alias format was not appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested triaged
Projects
None yet
Development

No branches or pull requests

3 participants