Skip to content

Commit b934b76

Browse files
authored
[RDSK-9415] remove parallelism when uploading to the registry (#32)
With this change, deploying to Viam's modular registry is done serially, so they should be in the order listed (jetpack 5, then jetpack 6, and finally cuda). This should be the right order: without tag priorities (which are in a [backlogged ticket](https://viam.atlassian.net/browse/APP-6759), your machine will get the earliest-uploaded module with compatible tags (so if your machine has both jetpack and cuda support, you'll get the jetpack version). Thanks to Abe for talking through this with me! I've also made some minor changes to bring this inline with Bijan's checklist for standardizing a CV module (renaming the file, having it trigger on the tags instead of the release type). I'm unsure how to actually test this out before merging it, though. Any ideas? * remove parallelism when uploading to the registry * use the tag format from Bijan's checklist * rename deploy.yml -> publish.yml in keeping with Bijan's checklist * add comments summarizing what each job does
1 parent 23fddb7 commit b934b76

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

.github/workflows/deploy.yml .github/workflows/publish.yml

+12-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
on:
22
push:
3-
release:
4-
types: [published]
3+
tags:
4+
- '[0-9]+.[0-9]+.[0-9]+'
5+
- '[0-9]+.[0-9]+.[0-9]+-rc'
6+
- '[0-9]+.[0-9]+.[0-9]+-rc[0-9]+'
57

68
env:
79
DOCKER_TAG: ghcr.io/${{ github.repository }}
810
VERSION: ${{ github.ref_name }}
911

1012
jobs:
11-
container:
13+
container: # Upload the docker image to the Github Container Registry
1214
strategy:
1315
matrix:
1416
build_target:
@@ -56,9 +58,15 @@ jobs:
5658
push: ${{ github.event_name == 'release' }}
5759
file: etc/docker/${{ matrix.build_target.dockerfile }}
5860
build-args: ${{ matrix.build_target.build_args }}
59-
module:
61+
module: # Upload the module to the Viam modular registry
6062
needs: [container]
6163
strategy:
64+
# Until Viam's tags get priorities, it is very important to deploy the Jetpack versions
65+
# *before* the CUDA versions. Otherwise, a Jetpack machine will use the CUDA version of the
66+
# module because it can (which will work, but miss out on the Jetpack-specific features). So,
67+
# remove the parallelization and do these uploads in order until tag priorities are supported
68+
# (see APP-6759).
69+
max-parallel: 1
6270
matrix:
6371
platform:
6472
- arch: arm64

0 commit comments

Comments
 (0)