Refactor ScubaDiver project #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've realized now that it may be easier to pick up #4 and refactor HTTP handling to use gRPC following this PR. The current implementation exists in a single file and is highly duplicative, which is terrible for maintainability. It is also very difficult to benchmark snapshot performance with the current architecture, which remains a blocker for #11. Currently, request types are stored in |
Qonfused
force-pushed
the
main
branch
3 times, most recently
from
3771558 to
4b26663
Compare
Qonfused
force-pushed
the
refactor-scubadiver
branch
from
be312b4 to
adbfa8b
Compare
Qonfused
commented
May 6, 2024
Move Bootstrapper class to resources namespace, removing conditional namespace imports for `MTGOSDK.Core`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor (and migration of) ClrMD handling and IL emitting from ScubaDiver to use new
MTGOSDK.Coremachinery.