New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "and" be used here if height <= crop_size or width <= crop_size: return (1, 1)? #247

Open

dyou-dev opened this issue Feb 19, 2025 · 1 comment

dyou-dev commented Feb 19, 2025

moondream/moondream/torch/image_crops.py

Line 15 in f102859

if height <= crop_size or width <= crop_size:

Should "and" be used here instead of "or"?
if height <= crop_size and width <= crop_size:
return (1, 1)

Author

dyou-dev commented Feb 19, 2025

With the original input 644x378, expected to get tiling 2x1, but here got 1x1, or 4x2 after using "and".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment