Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Review - Overall #2

Open
xtopolis opened this issue May 27, 2022 · 0 comments
Open

Website Review - Overall #2

xtopolis opened this issue May 27, 2022 · 0 comments

Comments

@xtopolis
Copy link

xtopolis commented May 27, 2022

Tooling / Deployment

Severity Description Notes
medium Self hosted assets should be minimized, concatenated when deployed reset.css, style.css
minor Strip comments from source files

UI/UX Experience

Severity Description Notes
minor Responsive: 320px breakpoint is not centered. Not critical, but it should try to be centered by default IMO responsive-320
minor Clicking multiple times spawns stacked tooltips Screen Shot 2022-05-26 at 8 50 34 PM
minor Chrome Lighthouse (dev tools tab) - Image dimensions, worth considering Screen Shot 2022-05-26 at 9 01 51 PM
minor At desktop size, the page scrolls unnecessarily, despite the content fitting in the viewport Screen Shot 2022-05-26 at 9 37 11 PM

Accessibility

Severity Description Notes
medium Password boxes are not able to be accessed via keyboard (pressing tab repeatedly), nor aria labeled Screen Shot 2022-05-26 at 8 57 20 PM
minor On my phone, the slider dot is a little hard to touch, perhaps make it a bit bigger radius?
minor Toggle element should have correct role attribute if masquerading as a button W3C validator
minor Voiceover If you access the page with Voiceover (CMD F5 [toggle on/off]) the slider announces weird. It's not critical, but highly regarded if you can accommodate screen readers well
@xtopolis xtopolis changed the title Website Review (WIP) Website Review - Overall May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant