Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi language #3

Closed
icf20 opened this issue May 10, 2017 · 10 comments
Closed

multi language #3

icf20 opened this issue May 10, 2017 · 10 comments

Comments

@icf20
Copy link

icf20 commented May 10, 2017

what needs to be changed in the theme to make it multi language ?

edit everything look to work nice except the _index.md & _header.md

@vjeantet
Copy link
Owner

Hello @icf20 , can you fork and try what you propose, i will then help you with _index.md & _header.md

@gwleclerc
Copy link

According to https://gohugo.io/content/multilingual/ it's not a big deal to make a theme multilingual

@vjeantet vjeantet reopened this May 12, 2017
@vjeantet
Copy link
Owner

reopened because _index.md and _header issue is still open

@icf20
Copy link
Author

icf20 commented May 16, 2017

never mind i figured out that is better to run this like 4 separate projects one for each language so is easier to maintain

@vjeantet vjeantet reopened this May 16, 2017
@marteaurouge
Copy link

is the multi language still planned, or is running several projects separately more simple?

@vjeantet
Copy link
Owner

labels used but the theme are localized (FR and EN) , not sure about the multi language hugo, i tried to follow gohugo documentation but i failed.

I have no estimated date to fully support (and understand) it.

@tonivj5
Copy link

tonivj5 commented Jul 19, 2017

Hi @vjeantet I have used your theme to a project (qontu/ngx-inline-editor#79) and I have modified it to add multilingual support, if you want I can do a PR to add my changes and a small setup guide 😄

An image of language menu 😉
image

URL of the multilingual docs
https://xxxtonixxx.github.io/ngx-inline-editor/en/

Thanks for your work in this hugo theme, it's awesome! 👍

@vjeantet
Copy link
Owner

¡ Ola !

Yes please send your PR with your implementation and your doc, i'll merge it

Thanks a lot

@matcornic
Copy link

Hey @vjeantet . I implemented this feature in v2 of Learn. Feel free to cherry pick the code.

@tonivj5
Copy link

tonivj5 commented Oct 30, 2017

It was implemented by @jose-oc in #97. This issue can be closed! 🎉 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants