Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glue js/c #32

Closed
altafan opened this issue Feb 21, 2023 · 1 comment
Closed

Update glue js/c #32

altafan opened this issue Feb 21, 2023 · 1 comment
Assignees

Comments

@altafan
Copy link
Collaborator

altafan commented Feb 21, 2023

In #85 we are changing the zkp interface, which is an effort to improve the usability, maintainability and readability of the this secp256k1-zkp lib.

Along with #31, we must also update the js/c glue to be compliant with the new interface:

The main changes involve:

  • renaming Ec as Ecc and declaring it as extension of tiny-secp interface
  • replacing Buffer with Uint8Array for browser support
  • replacing number with string to prevent any conversion issue from js to c
  • removing serialize/parse methods (implementation details that should be hided in out abstraction)
  • representing surjection proof as Uint8Array instead of object with low-level details
  • renaming and re-ordering some methods' args for readability
@altafan altafan self-assigned this Feb 21, 2023
@altafan
Copy link
Collaborator Author

altafan commented Mar 8, 2023

Closed by #33..#37

@altafan altafan closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant