Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour when combining Equivalent and LCS options #31

Open
will-isovalent opened this issue Jan 13, 2025 · 2 comments
Open

Comments

@will-isovalent
Copy link

I would have expected to be able to use these together, however it seems that they are mutually exclusive based on a cursory look at the code and some experimental results. The behaviour I have in mind would be something like: do Equivalent comparison and then fall back to LCS if the arrays are not equivalent.

@wI2L
Copy link
Owner

wI2L commented Jan 13, 2025

You're right, compareArraysLCS ignores the Equivalent() option.

That's mostly an oversight on my part, the lengths of the source and target arrays can be compared and if they are equal, deeply compare them before doing the LCS diff.

I'll add this in the next version. Thanks for the report.

@will-isovalent
Copy link
Author

Awesome, thank you for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants