Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix type discrepancy of IFilter with implementation #2224

Open
weboko opened this issue Jan 27, 2025 · 1 comment
Open

bug: fix type discrepancy of IFilter with implementation #2224

weboko opened this issue Jan 27, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@weboko
Copy link
Collaborator

weboko commented Jan 27, 2025

Description

Currently IFilter interface is missing definition of createSubscription method from here but hast implementation of it here

Expected Behavior

Type definition should be aligned with implementation.

Steps to Reproduce

N/A

Environment Details

Version: @waku/sdk: 0.29.0

@weboko weboko added this to Waku Jan 27, 2025
@weboko weboko moved this to Triage in Waku Jan 27, 2025
@weboko
Copy link
Collaborator Author

weboko commented Jan 30, 2025

Todo:

  • check if we need to define createSubscription as we want consumers use subscribe method;
  • check docs website to see if it is not advertised there;

@weboko weboko added the bug Something isn't working label Jan 30, 2025
@weboko weboko moved this from Triage to To Do in Waku Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To Do
Development

No branches or pull requests

1 participant