Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sds: Implement double-hashing strategy for BloomFilter hash functions #2226

Closed
adklempner opened this issue Jan 27, 2025 · 0 comments · Fixed by #2253
Closed

sds: Implement double-hashing strategy for BloomFilter hash functions #2226

adklempner opened this issue Jan 27, 2025 · 0 comments · Fixed by #2253
Assignees
@adklempner

Comments

@adklempner
Copy link
Member

  1. Create hash function interface that:

    • Accepts string or Uint8Array input
    • Generates k different hash values using double-hashing technique
    • Maps hash values to the correct bit array positions

  2. Implement primary hash function

    • ensure that behavior is equivalent to nim-sds
@chair28980 chair28980 added this to Waku Jan 27, 2025
@adklempner adklempner self-assigned this Jan 29, 2025
@adklempner adklempner moved this to In Progress in Waku Jan 29, 2025
@adklempner adklempner mentioned this issue Feb 6, 2025
Merged
5 tasks
@adklempner adklempner moved this from In Progress to Code Review / QA in Waku Feb 6, 2025
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adklempner adklempner

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sds): migrate bloomfilter to bigint and import hashn function from nim waku-org/js-waku
1 participant
@adklempner