Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move Peer to PeerId #2246

Merged
merged 4 commits into from
Feb 5, 2025
Merged

feat: move Peer to PeerId #2246

merged 4 commits into from
Feb 5, 2025

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jan 31, 2025 •
edited
Loading

Problem / Description

During core protocol operations we often await peerStore to get us Peer based on PeerId.
Upon looking into the code, it appears as unnecessary step.

Solution

Replace that usage.

Notes

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 84.59 KB (-0.18% 🔽) 1.7 s (-0.18% 🔽) 496 ms (-21.96% 🔽) 2.2 s
Waku Simple Light Node 135.67 KB (-0.05% 🔽) 2.8 s (-0.05% 🔽) 542 ms (-26.18% 🔽) 3.3 s
ECIES encryption 22.73 KB (0%) 455 ms (0%) 209 ms (-44.17% 🔽) 664 ms
Symmetric encryption 22.23 KB (0%) 445 ms (0%) 168 ms (-0.48% 🔽) 612 ms
DNS discovery 70.8 KB (0%) 1.5 s (0%) 566 ms (+33.17% 🔺) 2 s
Peer Exchange discovery 71.79 KB (-0.01% 🔽) 1.5 s (-0.01% 🔽) 346 ms (-40.28% 🔽) 1.8 s
Local Peer Cache Discovery 65.39 KB (0%) 1.4 s (0%) 572 ms (+65.48% 🔺) 1.9 s
Privacy preserving protocols 76.52 KB (0%) 1.6 s (0%) 546 ms (-3.1% 🔽) 2.1 s
Waku Filter 78.11 KB (+0.01% 🔺) 1.6 s (+0.01% 🔺) 514 ms (-12.93% 🔽) 2.1 s
Waku LightPush 75.68 KB (+0.12% 🔺) 1.6 s (+0.12% 🔺) 691 ms (+76.52% 🔺) 2.3 s
History retrieval protocols 75.77 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 427 ms (-35.83% 🔽) 2 s
Deterministic Message Hashing 7.32 KB (0%) 147 ms (0%) 111 ms (-15.17% 🔽) 258 ms

@weboko weboko marked this pull request as ready for review February 4, 2025 15:19
@weboko weboko requested a review from a team as a code owner February 4, 2025 15:19
@weboko weboko merged commit fc93fae into master Feb 5, 2025
11 of 12 checks passed
@weboko weboko deleted the weboko/peer-to-id branch February 5, 2025 10:21
@weboko weboko mentioned this pull request Feb 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adklempner adklempner adklempner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: make core protocols use PeerId only
2 participants
@weboko @adklempner