Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable redial on fails for Waku.dial() #2236

Open
danisharora099 opened this issue Jan 28, 2025 · 1 comment
Open

feat: enable redial on fails for Waku.dial() #2236

danisharora099 opened this issue Jan 28, 2025 · 1 comment

Comments

@danisharora099
Copy link
Collaborator

Description

When a consumer uses Waku.dial() to dial a peer, the function internally directly calls libp2p.dialProtocol(), and with the change in #2192 (comment), as a proxy but still directly calls libp2p.dial() -- this is fine until we want to tailor this connection to Waku's connection management:

A simple feature like Keep Alive Management is ignored in this process, along with lesser important but nice-to-have features like dial management (retries, backoffs), and connection tagging based on discovery method.

Expected Behavior

Any, and all, dials should have as much metadata along with crucial feature support like keep alive management a part of them

@chair28980 chair28980 added this to Waku Jan 28, 2025
@weboko weboko changed the title feat: external dials via Waku.dial() should have crucial feature support feat: enable redial on fails for Waku.dial() Jan 28, 2025
@weboko weboko moved this to Triage in Waku Jan 30, 2025
@weboko
Copy link
Collaborator

weboko commented Jan 30, 2025

Attack plan:

  • investigate if we need to provide;
  • enable keepAlive feature;
  • connection tagging if needed;

Most likely to be scoped under browser hardening milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants