Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): replace pubsubTopic references with shardInfo + clusterId #2240

Open
danisharora099 opened this issue Jan 29, 2025 · 0 comments
Labels
test Issue related to the test suite with no expected consequence to production code

Comments

@danisharora099
Copy link
Collaborator

danisharora099 commented Jan 29, 2025

Description

The nwaku node is deprecating the usage of pubsubTopic in favor of using shardInfo + clusterId. While the initial PR (#2239) updated the CI configuration, we need to update our test suite to align with this change.
Currently, our test suite in the packages/tests directory still contains many references to pubsubTopic when interacting with nwaku/service node. These should be converted to use shardInfo types to match nwaku's new approach.

User Story

As a Waku developer, I want to update our test suite to use shardInfo + clusterId instead of pubsubTopic when interacting with nwaku, so that:

  • Our tests reflect the current best practices for nwaku configuration
  • We maintain consistency with nwaku's deprecation of pubsubTopic

Proposed Solution / Feature Design

  1. Audit and update test files in packages/tests to:
  • Replace direct pubsubTopic usage with appropriate shardInfo + clusterId combinations
  • Update test utilities and helpers to use sharding-based APIs
  • Maintain compatibility with nwaku's REST API which still uses pubsubTopic in endpoints
  1. Key files to update:
  • packages/tests/src/lib/service_node.ts: Update interface while maintaining REST API compatibility
  • Test files under packages/tests/tests/ that use pubsubTopic directly
  • Test utilities and helpers that generate test data with pubsubTopic
  • Ensure all tests continue to pass with the updated approach
@chair28980 chair28980 added this to Waku Jan 29, 2025
@weboko weboko added the test Issue related to the test suite with no expected consequence to production code label Jan 29, 2025
@weboko weboko moved this to Triage in Waku Jan 29, 2025
@weboko weboko moved this from Triage to To Do in Waku Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issue related to the test suite with no expected consequence to production code
Projects
Status: To Do
Development

No branches or pull requests

2 participants