Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint:fix script not present in app package.json #3

Open
knownasilya opened this issue Jul 10, 2022 · 2 comments
Open

lint:fix script not present in app package.json #3

knownasilya opened this issue Jul 10, 2022 · 2 comments

Comments

@knownasilya
Copy link
Collaborator

knownasilya commented Jul 10, 2022

ember-cli expects a lint:fix script which it uses when running blueprint generators, like ember g helper test. It returns this message:

WARNING: Lint fix skipped: "lint:fix" not found in package.json scripts. New files might not pass linting.
@knownasilya knownasilya changed the title lint:fix not present in app package.json lint:fix script not present in app package.json Jul 10, 2022
@runspired
Copy link
Contributor

we may want to stub it to do nothing, else we'll want it to run lint from the root level vs from within the app/addon.

That said I feel it's likely we replace the default ember blueprints with engage versions, should speed up the process not having all the ember cruft in the blueprint timeline making scaffolding nicer all around, and that way we can match output to the conventions of the pod setup that apps are configured for (pods for route templates/files/controllers only, classic/co-location everything else)

@knownasilya
Copy link
Collaborator Author

I like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants