Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

Enforce ids for panel, content, move handle and resize handle #19

Open
safaorhan opened this issue May 20, 2020 · 0 comments
Open

Enforce ids for panel, content, move handle and resize handle #19

safaorhan opened this issue May 20, 2020 · 0 comments
Labels
library Issues regarding the library itself

Comments

@safaorhan
Copy link
Collaborator

Background

In the current state, user gives ids of panel, content, move handle and resize handle using XML attributes:

panel_view, panel_content, panel_move_handle and panel_resize_handle.

However in the default layouts for left/top/right/bottom snaps the panel and content ids are hardcoded.

This creates a serious bug: When default snap layouts are used with ids different than panel and content snap layouts do not work and the panel cannot be snapped.

TODO

  • Expose predefined ids for panel, content, move and resize handles and enforce those ids.
  • Remove panel_view, panel_content, panel_move_handle and panel_resize_handle attributes.
  • Update API docs if necessary.

Notes:

  • This will make a breaking change.
@safaorhan safaorhan added the library Issues regarding the library itself label May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
library Issues regarding the library itself
Projects
None yet
Development

No branches or pull requests

1 participant