Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Weird failure (when hiding all connector pins) #327

Closed
cmjdev opened this issue Dec 25, 2023 · 2 comments
Closed

[bug] Weird failure (when hiding all connector pins) #327

cmjdev opened this issue Dec 25, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@cmjdev
Copy link

cmjdev commented Dec 25, 2023

Sorry for the lack of description. I don't know how to explain this.

The following yaml works. If I try and remove or comment out the LINK.PDM connection it fails with the following error:
graphviz.backend.execute.CalledProcessError: Command '[WindowsPath('dot'), '-Kdot', '-Tpng', '-O', 'test']' returned non-zero exit status 1. [stderr: b'Error: syntax error in line 15 \r\n... \r\n </table> ...\r\n']

The working/non-working code:

connectors:
  LINK.PDM:
    hide_disconnected_pins: true
    pinlabels:
      [PWROUT2,NC,CANH,IGNSW,5V,SGND,PWROUT3,PWROUT2B,NC,CANL,5V,SGND,PWROUT3B,PWROUT1,ADIO2,ADIO4,ADIO6,ADIO8,PWROUT4,PWROUT1B,ADIO1,ADIO3,ADIO5,ADIO7,NC,PWROUT4B,]
  HW.PDM.A:
    # pins: [A1,A2,A3,A4,A5,A6,A7,A8,A9,A10,A11,A12]
    pinlabels: [IN.12,IN.10,IN.8,IN.6,IN.4,IN.2,IN.1,IN.3,IN.5,IN.7,IN.9,IN.11]
  HW.PDM.B:
    pins: [B1,B2,B3,B4,B5,B6,B7,B8,B9,B10,B11,B12]
    pinlabels: [NC,NC,NC,OUT.15,OUT.14,OUT.13,OUT.10,OUT.11,OUT.12,NC,NC,NC]
  HW.PDM.C:
    pins: [C1,C2,C3,C4,C5,C6,C7,C8,C9,C10,C11,C12]
    pinlabels: [IN.16,IN.15,IGN12V,OUT.3,OUT.2,OUT.1,GND,CAN.H,CAN.L,5V,IN.13,IN.14]
  HW.PDM.D:
    pins: [D1,D2,D3,D4,D5,D6,D7,D8,D9,D10,D11,D12]
    pinlabels: [NC,NC,NC,OUT.9,OUT.8,OUT.7,OUT.4,OUT.5,OUT.6]
  
  # REAR DEVICES
  FAN.1:
    pinlabels: [12V, GND]
    show_pincount: false
  FAN.2:
    pinlabels: [12V, GND]
    show_pincount: false
  WP: # WATER PUMP
    pinlabels: [12V, GND]
    show_pincount: false
  FP.1: # LIFT PUMP
    pinlabels: [12V, GND]
    show_pincount: false
  FP.2: # PRIMARY PUMP
    pinlabels: [12V, GND]
    show_pincount: false
  CS: # COOL SUIT
    pinlabels: [12V, GND]
    show_pincount: false
  NOS.H: # NOS HEATER
    pinlabels: [12V, GND]
    show_pincount: false

cables:
  REAR.1:
    color_code: DIN
    show_wirecount: false
    show_wirenumbers: false
    wirecount: 10
  RGND.1:
    show_wirecount: false
    show_wirenumbers: false
    wirecount: 4

connections:
  -
    - HW.PDM.A: [IN.12,IN.10]
    - REAR.1: [6,7]
  -
    - HW.PDM.B: [OUT.15, OUT.14]
    - REAR.1: [6,7]
  - 
    - LINK.PDM: [1,2,3,4,5] # PWROUT1,PWROUT1,ADIO1,PWROUT2,PWROUT2
    - REAR.1: [1-5]

  
tweak:
  override:
    graph:
      ranksep: '6' # Larger horizontal separation between nodes
      splines: 'true' # Or ortho?
@cmjdev
Copy link
Author

cmjdev commented Dec 25, 2023

I've looked into this a bit more.. It looks like when no pins are connected and you're using hide_disconnected_pins: true it freaks out.. Not sure if this is bug or not but I'm good now. Feel free to close this if it's as designed.

@kvid
Copy link
Collaborator

kvid commented Dec 29, 2023

This bug report seems to be a duplicate of what is already reported in #257

@kvid kvid changed the title Weird failure [bug] Weird failure (when hiding all connector pins) Dec 29, 2023
@kvid kvid added the duplicate This issue or pull request already exists label Dec 31, 2023
@kvid kvid closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants