Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldd-check test pipeline failures #40629

Open
murraybd opened this issue Jan 27, 2025 · 4 comments
Open

ldd-check test pipeline failures #40629

murraybd opened this issue Jan 27, 2025 · 4 comments

Comments

@murraybd
Copy link
Member

murraybd commented Jan 27, 2025

While I've been adding the ldd-check test pipeline to a variety of packages it has only been to ones which pass testing. There are also many packages for which the ldd-check test pipeline fails and the majority of those are likely due to missing dependencies e.g. the nginx and mesa changes in #40553.

This is an overarching issue for such failures.

@murraybd murraybd changed the title lldd-check test pipeline failures ldd-check test pipeline failures Jan 27, 2025
@a-crate
Copy link
Contributor

a-crate commented Feb 7, 2025

#41002, #40838, #41304, #41305 are cases where a python module brings a shared object with it, and then that shared object links against a 2nd shared object brought by the same module.
In this case SO1 links against SO2 using just the library name (instead of a relative path), which the python interpreter allows by loading objects in the same directory before looking elsewhere.

ldd doesn't do this by default, the test procedure will have to add the object's directory to LD_LIBRARY_PATH for python modules to test this.

#40831, #40843, #40842 have cases of this but they also have some other ldd failures unrelated to python stuff

@murraybd
Copy link
Member Author

murraybd commented Feb 7, 2025

#41002, #40838, #41304, #41305 are cases where a python module brings a shared object with it, and then that shared object links against a 2nd shared object brought by the same module. In this case SO1 links against SO2 using just the library name (instead of a relative path), which the python interpreter allows by loading objects in the same directory before looking elsewhere.

ldd doesn't do this by default, the test procedure will have to add the object's directory to LD_LIBRARY_PATH for python modules to test this.

Will that only cause the test to pass i.e. does something more need to be done for the package to be fully functional?

@a-crate
Copy link
Contributor

a-crate commented Feb 7, 2025

It will only cause the test to pass, but nothing more needs to be done as the packages are already fully functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants