Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Handle card reader power off gracefully #13738

Closed
joshheald opened this issue Aug 26, 2024 · 4 comments · Fixed by #14995
Closed

[Woo POS] Handle card reader power off gracefully #13738

joshheald opened this issue Aug 26, 2024 · 4 comments · Fixed by #14995
Assignees
Labels
feature: POS priority: high Affects lots of customers substantially, but not critically. type: bug A confirmed bug.

Comments

@joshheald
Copy link
Contributor

joshheald commented Aug 26, 2024

Turning the reader off

It's not possible to turn the reader off while it's primed to accept payment, so it doesn't matter that we don't get an opportunity to cancel the payment like we do when disconnecting it.

If you turn it off while a payment is processing, we get the full-screen Connect your reader view, with either a purple or green background depending which screen you do it on.

I think we should handle that on a separate PR, as this one's getting a little large and in fixing it, there are some risks to overcome, particularly when the reader gets turned off on the card payment success screen.

Originally posted by @joshheald in #13720 (comment)

Risks

If you turn off the reader on the card payment success screen, then tap Connect your reader and reconnect, you're taken to the checkout view again.

If you don't change the order, just go back to the product selector and forwards again, it correctly tells you the order is already paid for.

However, if you go back to the cart and change the order, then go forward again, it will still tell you that the order's been paid for without any further card tap. Worse, it will show you the new total as well. This is because you're in the same order still, and it datePaid != nil

This presents the risk that a merchant may get confused and think they've made a new order, and give away items that aren't paid for to the new customer.

This was true before the PR above, where we discovered this issue.

@dangermattic
Copy link
Collaborator

dangermattic commented Aug 26, 2024

Thanks for reporting! 👍

@joshheald joshheald added type: task An internally driven task. feature: POS labels Aug 26, 2024
@malinajirka malinajirka added the priority: high Affects lots of customers substantially, but not critically. label Jan 25, 2025
@malinajirka
Copy link
Contributor

malinajirka commented Jan 25, 2025

This could potentially lead to quite some confusions - we shouldn't navigate anywhere from the success screen upon card-reader status change. I'm moving this to our current backlog.

P.S. I haven't tested whether this issue is still present.

@joshheald
Copy link
Contributor Author

I can't reproduce this right now. Turning off the reader doesn't actually update the Reader connected status, so you can't tap Connect your reader because the POS thinks you still are connected. It's also not possible to disconnect the reader on the success screen.

That said, this issue may still exist when we fix whatever's causing the reader connected status not to change.

@joshheald joshheald self-assigned this Jan 27, 2025
@joshheald joshheald added priority: medium Planned tasks usually belonging to ongoing projects type: bug A confirmed bug. and removed priority: high Affects lots of customers substantially, but not critically. type: task An internally driven task. labels Jan 27, 2025
@joshheald
Copy link
Contributor Author

After fixing the issue where Reader connected didn't update to Connect your reader after turning off the reader, this becomes reproducible again. I'll work on this next.

@joshheald joshheald added priority: high Affects lots of customers substantially, but not critically. and removed priority: medium Planned tasks usually belonging to ongoing projects labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS priority: high Affects lots of customers substantially, but not critically. type: bug A confirmed bug.
Projects
None yet
4 participants
@malinajirka @joshheald @dangermattic and others