-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Handle card reader power off gracefully #13738
Comments
Thanks for reporting! 👍 |
This could potentially lead to quite some confusions - we shouldn't navigate anywhere from the success screen upon card-reader status change. I'm moving this to our current backlog. P.S. I haven't tested whether this issue is still present. |
I can't reproduce this right now. Turning off the reader doesn't actually update the That said, this issue may still exist when we fix whatever's causing the reader connected status not to change. |
After fixing the issue where |
Originally posted by @joshheald in #13720 (comment)
Risks
If you turn off the reader on the card payment success screen, then tap
Connect your reader
and reconnect, you're taken to the checkout view again.If you don't change the order, just go back to the product selector and forwards again, it correctly tells you the order is already paid for.
However, if you go back to the cart and change the order, then go forward again, it will still tell you that the order's been paid for without any further card tap. Worse, it will show you the new total as well. This is because you're in the same order still, and it
datePaid != nil
This presents the risk that a merchant may get confused and think they've made a new order, and give away items that aren't paid for to the new customer.
This was true before the PR above, where we discovered this issue.
The text was updated successfully, but these errors were encountered: