[Order Editing] Cancelling an order edit in split view with unsynced changes doesn't request confirmation.

[joshheald]

          There are no issues with this logic but it revealed an issue with `canBeDismissed: Bool` when testing.

    var canBeDismissed: Bool {
        switch flow {
        case .creation: // Creation can be dismissed when there aren't changes pending to commit.
            return !hasChanges
        case .editing: // Editing can always be dismissed because changes are committed instantly.
            return true
        }
    }

When we edit on an iPad, then if we make changes in a product picker and click dismiss, we don't show an alert.

I think it should be:

    var canBeDismissed: Bool {
        switch flow {
        case .creation: // Creation can be dismissed when there aren't changes pending to commit.
            return !hasChanges
        case .editing: // Editing can always be dismissed on iPhone because changes are committed instantly.
            return !(selectionSyncApproach == .onRecalculateButtonTap && hasChanges)
        }
    }

Originally posted by @staskus in #14907 (comment)

Agreed... however I've just had a go at fixing that, and opens a can of worms which I don't want to dive in to right now.

1. If you change it as suggested, discarding the changes during editing deletes the order.
2. If you prevent the deletion, making an edit, tapping cancel, then continuing with the edit instead of discarding it breaks the Recalculate button (and I have no idea why...)

To get most of the fix out, I'm going to log this as a separate issue... but it'll be pretty low priority, I think.

[dangermattic]

Thanks for reporting! 👍