Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] [Cash & Receipts] Enable acceptCashForPointOfSale #14884

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jan 16, 2025

Closes: #14832

Ideally let's merge #14919 and #14935 first, but it's not a blocker.

Description

Sets acceptCashForPointOfSale to true, enabling cash in POS for release builds

Testing

  • Run the app on Release build configuration
  • Navigate to POS, proceed to add items to cart and checkout.
  • Observe the "Cash Payment" option is available and functional

Simulator Screenshot - iPad Air 11 - iOS 17 5 M2 - 2025-01-15 at 12 37 55


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Jan 16, 2025
@iamgabrielma iamgabrielma added this to the 21.5 milestone Jan 16, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review January 16, 2025 01:29
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 16, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14884-6e3fb1b
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit6e3fb1b
App Center BuildWooCommerce - Prototype Builds #12663
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@joshheald joshheald self-assigned this Jan 23, 2025
@joshheald
Copy link
Contributor

@iamgabrielma I noticed one thing the other day; the string for collecting payments mentions cash, even when the feature flag is off. It might not be the best use of time, but for best practice, it would be good to make sure we use the old string if we turn the flag off.

@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Jan 23, 2025

@iamgabrielma I noticed one thing the other day; the string for collecting payments mentions cash, even when the feature flag is off. It might not be the best use of time, but for best practice, it would be good to make sure we use the old string if we turn the flag off.

That's a very good point, sorry for that. It was done in the context of an unrelated issue (animations) as a low-priority thing found during testing, and I didn't think about the flag.

I've updated the logic in this same PR: a02f3bb and restored the old String as cardOnlyInstruction. Also confirmed Strings are different when the flag is on/off and nothing is off due localized string values conflicting.

Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing the string.

@iamgabrielma iamgabrielma merged commit 0f20c7a into trunk Jan 23, 2025
12 checks passed
@iamgabrielma iamgabrielma deleted the task/14832-pos-cash-receipts-switch-f-flag branch January 23, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] [Cash & Receipts] Remove feature flag
4 participants