-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] [Cash & Receipts] Enable acceptCashForPointOfSale
#14884
[Woo POS] [Cash & Receipts] Enable acceptCashForPointOfSale
#14884
Conversation
|
@iamgabrielma I noticed one thing the other day; the string for collecting payments mentions cash, even when the feature flag is off. It might not be the best use of time, but for best practice, it would be good to make sure we use the old string if we turn the flag off. |
That's a very good point, sorry for that. It was done in the context of an unrelated issue (animations) as a low-priority thing found during testing, and I didn't think about the flag. I've updated the logic in this same PR: a02f3bb and restored the old String as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing the string.
Closes: #14832
Ideally let's merge #14919 and #14935 first, but it's not a blocker.
Description
Sets
acceptCashForPointOfSale
to true, enabling cash in POS for release buildsTesting
Release
build configurationRELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: