Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sentry library from v.8.36.0 to v.8.43.0 #14922

Merged

Conversation

pmusolino
Copy link
Member

Description

I updated the Sentry library from v8.36.0 to v8.43.0 to check if this upgrade would fix this issue discussed also here pe5sF9-3IY#comment-4282, but it does not. Anyway, I think it's good to keep it updated.

Testing information

Sentry logs should work like before.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@pmusolino pmusolino added the type: technical debt Represents or solves tech debt of the project. label Jan 20, 2025
@pmusolino pmusolino added this to the 21.5 milestone Jan 20, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 20, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14922-934b30c
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit934b30c
App Center BuildWooCommerce - Prototype Builds #12615
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo
Copy link
Contributor

Should we go over the changelogs of the versions and see what could affect us/what should be tested?

@pmusolino
Copy link
Member Author

@itsmeichigo I checked all the changelogs from 8.36.0 to 8.43.0, and it seems they:

  • Added some options for the reports.
  • Changes regarding visionOS.
  • Experimental feature: transactions for crashes, disabled by default.
  • Added in_foreground app context to transactions and crash events.
  • Some fixes

In general, I don't see anything that can affect directly WCiOS in wrong ways.

@itsmeichigo itsmeichigo self-assigned this Jan 24, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@wpmobilebot wpmobilebot modified the milestones: 21.5, 21.6 Jan 24, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.5 has now entered code-freeze, so the milestone of this PR has been updated to 21.6.

@pmusolino pmusolino merged commit 246851e into trunk Jan 27, 2025
13 checks passed
@pmusolino pmusolino deleted the update/update-sentry-library-from-v8-36-0-to-v-8-43-0 branch January 27, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: technical debt Represents or solves tech debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance Warning: Repeated Invocation of Callbacks in sentry_dyld_register_func_for_add_image
3 participants