Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping labels] Add Yosemite support for address validation #14934

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Jan 21, 2025

Part of: #13780
⚠️ Based on #14933 ⚠️

Description

This adds support in the Yosemite layer for validating an address for the Woo Shipping extension.

It updates WooShippingAction and WooShippingStore to add an action that calls the remote endpoint to validate an address.

Testing information

This action isn't yet used; confirm unit tests pass.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@rachelmcr rachelmcr added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Jan 21, 2025
@rachelmcr rachelmcr added this to the 21.5 milestone Jan 21, 2025
@rachelmcr rachelmcr requested a review from toupper January 21, 2025 11:39
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14934-c2109b9
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commitc2109b9
App Center BuildWooCommerce - Prototype Builds #12619
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@toupper toupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 :shipit:

Copy link
Contributor

@toupper toupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 :shipit:

Base automatically changed from issue/13780-normalize-address-networking to trunk January 22, 2025 10:35
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@rachelmcr rachelmcr merged commit 9d932c6 into trunk Jan 22, 2025
19 of 22 checks passed
@rachelmcr rachelmcr deleted the issue/13780-normalize-address-yosemite branch January 22, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants