Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert version comparison tests to swift testing #14947

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Jan 22, 2025

Description

Because the 9.6.0-beta woo builds weren't showing as eligible for POS, I investigated the version compare algorithm.

It is working correctly, we should have specified 9.6.0-beta as the minimum, not 9.6.0.

While I was investigating, I improved the tests by moving them to swift testing, and adding a comment which explains any failures; previously when there were failures it wouldn't tell you why.

Testing information

No code changes, just check the tests pass.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Jan 22, 2025
@joshheald joshheald added this to the 21.5 milestone Jan 22, 2025
@joshheald joshheald requested a review from staskus January 22, 2025 15:58
@joshheald joshheald changed the base branch from feat/14834-replace-local-filtering to issue/14945-match-variation-order-with-wp-admin-menu-order January 22, 2025 15:58
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14947-3185c7f
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit3185c7f
App Center BuildWooCommerce - Prototype Builds #12649
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

It is working correctly, we should have specified 9.6.0-beta as the minimum, not 9.6.0.

9.6.0-beta being considered below 9.6.0 makes so much sense but I haven't thought our checks work this way. A good learning 👍

@joshheald joshheald merged commit a81490c into issue/14945-match-variation-order-with-wp-admin-menu-order Jan 23, 2025
21 of 25 checks passed
@joshheald joshheald deleted the fix/make-version-comparison-respect-rc-or-beta-builds branch January 23, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants