Convert version comparison tests to swift testing #14947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because the
9.6.0-beta
woo builds weren't showing as eligible for POS, I investigated the version compare algorithm.It is working correctly, we should have specified 9.6.0-beta as the minimum, not 9.6.0.
While I was investigating, I improved the tests by moving them to swift testing, and adding a comment which explains any failures; previously when there were failures it wouldn't tell you why.
Testing information
No code changes, just check the tests pass.
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: