Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update App Store Connect Copyright Date #14951

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update App Store Connect Copyright Date #14951

merged 2 commits into from
Jan 23, 2025

Conversation

spencertransier
Copy link
Contributor

@spencertransier spencertransier commented Jan 22, 2025 •
edited
Loading

What it does

This updates the copyright uploaded to App Store Connect to be derived so we won't have to manually update it each year.. It'll be updated on App Store Connect during the next release cycle.

@spencertransier spencertransier added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jan 22, 2025
@spencertransier spencertransier added this to the 21.5 milestone Jan 22, 2025
@spencertransier spencertransier requested a review from a team January 22, 2025 21:56
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 22, 2025 •
edited
Loading

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14951-7838499
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commit7838499
App Center BuildWooCommerce - Prototype Builds #12654
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

mokagio
mokagio approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

The code is the same as wordpress-mobile/WordPress-iOS#24006 (review) so I did not test it.

@spencertransier spencertransier merged commit c0354b0 into trunk Jan 23, 2025
13 checks passed
@spencertransier spencertransier deleted the update/copyright branch January 23, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio approved these changes

Assignees
No one assigned
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Milestone
21.5
Development

Successfully merging this pull request may close these issues.
4 participants
@spencertransier @dangermattic @wpmobilebot @mokagio