Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] [Variable Products] Only show one ghost cell for next page #14956

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Jan 23, 2025

Closes: #14955

Description

This PR changes the loading next page UI for products and variations to match Android.

We now show only one ghost cell when loading the next page, but continue to show 8 when loading the first page of variations.

Steps to reproduce

  1. Launch the app and open POS
  2. Observe that the initial loading state is a spinner.
  3. Scroll to the end of the product list; observe that one ghost cell is shown while loading new items.
  4. Open a variation; observe that the loading state is a page of ghost cells which all animate.
  5. Scroll to the end of the list (min 26 variations); observe that the loading state for the next page is one ghost cell.

Testing information

Screenshots

ghost.cell.updates.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Jan 23, 2025
@joshheald joshheald added this to the 21.5 milestone Jan 23, 2025
@joshheald joshheald requested a review from staskus January 23, 2025 09:44
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14956-a3b15eb
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commita3b15eb
App Center BuildWooCommerce - Prototype Builds #12660
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that only one ghost cell is visible when scrolling to the next page. 👍

@joshheald joshheald merged commit 65a7b39 into trunk Jan 23, 2025
21 of 25 checks passed
@joshheald joshheald deleted the issue/14955-only-show-one-ghost-cell-for-next-page branch January 23, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Only show one skeleton cell when loading next page
4 participants