-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Revamp Shipping Labels • Customs] Sync form #14959
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
We don't sync the data remotely yet, we will test that the customs information is properly sent after implementing the shipping label request.
We did already implement support for the shipping label purchase (as part of M1). But for the full flow to make sense I believe we need to limit the customs form to only international shipments.
@@ -38,7 +38,7 @@ final class WooShippingCustomsFormViewModel: ObservableObject { | |||
@Published var itemsViewModels: [WooShippingCustomsItemViewModel] = [] | |||
|
|||
func onDismiss() { | |||
// TODO: Add missing values if possible | |||
// Package Id and Name not necessary to sync remotely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about this; won't we eventually need to include the package ID/name so we can support multiple shipments (where each shipment may have its own customs form)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I updated the comment here 0fafeb8
Version |
Part of: #13784
Description
With this PR we sync the customs form to be sent remotely. We also implement the logic of whether the customs information is completed, and keep the customs view model so the data can be edited after the view is closed and re-opened.
Steps to reproduce
Verify in Xcode through a breakpoint in
onCustomsFormFilled:
inWooShippingCreateLabelsViewModel
to verify that the data is changed.Testing information
We don't sync the data remotely yet, we will test that the customs information is properly sent after implementing the shipping label request.
We also fix here this comment where selections aren't being preserved on device rotation. Here, as we keep a reference to the
WooShippingCustomsFormViewModel
the input data remains.Screenshots
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-23.at.11.03.51.mp4
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: