Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brand Updates] Update In-Person mentions to make sure we use non-breaking hyphen #14966

Conversation

hichamboushaba
Copy link
Member

Description

As part of the design review of the app, we got feedback about in-person breaking and pushing person to new line.
This PR updates those cases to use a non-breaking hyphen, and also updates the localizable comment to mention this for translators, this follows the same approach we are already doing in other areas.

Steps to reproduce

I think code review should be enough here.

Testing information

Tested the plugin not installed case to confirm this works as expected.
Tested using an iPhone 16 simulator, iOS 18.1

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2025-01-23 at 16 12 40 Simulator Screenshot - iPhone 16 - 2025-01-23 at 15 19 05

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added the category: i18n Related to localization/internationalization. label Jan 23, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 23, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14966-c0509f9
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commitc0509f9
App Center BuildWooCommerce - Prototype Builds #12678
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@hichamboushaba hichamboushaba force-pushed the task/woo-2.0-in-person-breaking-logic branch from b04d88e to 2b957a1 Compare January 23, 2025 16:23
@hichamboushaba hichamboushaba marked this pull request as ready for review January 23, 2025 16:23
@hichamboushaba hichamboushaba force-pushed the task/woo-2.0-in-person-breaking-logic branch from 2b957a1 to c0509f9 Compare January 23, 2025 16:37
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@itsmeichigo itsmeichigo self-assigned this Jan 24, 2025
@hichamboushaba hichamboushaba merged commit b3a9ca5 into feature/woo-2.0-brand-updates Jan 24, 2025
12 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-in-person-breaking-logic branch January 24, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: i18n Related to localization/internationalization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants