Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brand Updates] Update Jetpack setup illustrations in dark theme #14973

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jan 24, 2025

Description

During the design review, it was commented that the illustrations we use for Jetpack setup flow don't look great in dark theme, so we got new versions that use lighter purple, this PR updates those illustrations:

Steps to reproduce

Checking the screenshots below should be enough.

Testing information

Tested on an iPhone 16 simulator, iOS 18.1.

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 20 04 Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 15 09
Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 18 56 Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 16 32
Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 19 18 Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 16 05
Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 22 01 Simulator Screenshot - iPhone 16 - 2025-01-24 at 12 23 04

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 24, 2025
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14973-f19bea7
Version21.4
Bundle IDcom.automattic.alpha.woocommerce
Commitf19bea7
App Center BuildWooCommerce - Prototype Builds #12690
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@hichamboushaba hichamboushaba marked this pull request as ready for review January 24, 2025 11:30
@pmusolino pmusolino self-assigned this Jan 24, 2025
Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hichamboushaba hichamboushaba merged commit 854aa80 into feature/woo-2.0-brand-updates Jan 24, 2025
18 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-address-design-feedback branch January 24, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants