fix: modify JetpackSetupCoordinator to dismiss progressView upon successful setup completion

[pmusolino]

Closes: #14975

Description

After logging into a store where Jetpack is not connected (whether or not Jetpack is installed), @rachelmcr encountered an issue where the process gets stuck on the "Syncing data" screen after installing or connecting Jetpack.
This happens because there is a progressView.dismiss(animated: true) missing if the connection is successful.

Steps to reproduce

1. Log in to a store where Jetpack is not connected.
2. Go to Menu > Settings > Install Jetpack.
3. Follow the steps to install/connect Jetpack.
4. After the installation is complete, tap the "Go to Store" button.
5. Notice a "Syncing data" progress view appears and is never dismissed.

Testing information

There are 4 cases that I tested on a Jurassic Ninja store.

Case 1

1. Log in to a store where Jetpack is installed but NOT connected.
2. Go to Menu > Settings > Install Jetpack.
3. Follow the steps to install/connect Jetpack.
4. After the installation is complete, tap the "Go to Store" button.
5. Notice a "Syncing data" progress view appears and gets correctly dismissed.

Case 2

1. Log in to a store where Jetpack is NOT installed and NOT connected.
2. Go to Menu > Settings > Install Jetpack.
3. Follow the steps to install/connect Jetpack.
4. After the installation is complete, tap the "Go to Store" button.
5. Notice a "Syncing data" progress view appears and gets correctly dismissed.

Case 3

1. Log in to a store where Jetpack is installed but NOT connected.
2. From the Dashboard, press the banner to install/connect Jetpack.
3. Follow the steps to install/connect Jetpack.
4. After the installation is complete, tap the "Go to Store" button.
5. Notice a "Syncing data" progress view appears and gets correctly dismissed.

Case 4

1. Log in to a store where Jetpack is NOT installed and NOT connected.
2. From the Dashboard, press the banner to install/connect Jetpack.
3. Follow the steps to install/connect Jetpack.
4. After the installation is complete, tap the "Go to Store" button.
5. Notice a "Syncing data" progress view appears and gets correctly dismissed.

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 21.4. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14981-3b7238b
	Version	21.4
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	3b7238b
	App Center Build	WooCommerce - Prototype Builds #12700

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[hichamboushaba]

Thanks @pmusolino for the quick fix, this worked well in my tests.

There is still a case regarding sites connected to Jetpack using Jeptack CP, and accessed using site credentials, we fail to show the remaining of the setup steps, but I think this was broken for quite some time, and it's the case where XCode logs the message I mentioned in the P2:

Attempt to present <WooCommerce.JCPJetpackInstallHostingController: 0x13c072000> on <SwiftUI.UIKitNavigationController: 0x11302a800> (from <SwiftUI.UIKitNavigationController: 0x11302a800>) whose view is not in the window hierarchy.

Anyway, this case is an edge case that we can investigate separately, I'll create a ticket later with more details.
Your fix now fixes the more urgent issue, so , I just left on non-blocking suggestion.

[hichamboushaba]

I suggest we move this to the self.stores.synchronizeEntities onCompletion, to make sure we are not dismissing the progress view until we finish all tasks, WDYT?

[pmusolino]

Yes it makes sense, updated here 3b7238b