-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] MVP analytics: Track remaining MVP events and properties #15151
Conversation
Generated by 🚫 Danger |
|
…k/pos-remaining-mvp-events # Conflicts: # WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalytics.swift # WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Works as expected. The only comment is to align orderCreated
event with Android and call it even if order hasn't changed.
@@ -83,6 +96,11 @@ final class POSCollectOrderPaymentAnalytics: CollectOrderPaymentAnalyticsTrackin | |||
func resetCheckoutTapCountTracker() { | |||
checkoutTapCount = 0 | |||
} | |||
|
|||
private func trackElapsedTimeFromOrderCreationToCardReady() { | |||
let elapsedTime = cardReaderReady - orderCreated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's track orderCreated
both when newOrder
is created and the existing one is reused to align with Android p1739888487411149/1739867347.923049-slack-C070SJRA8DP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Updated here: 1bafc53 and confirmed that we only track it on newOrder
and orderUpdated
cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
|
||
static func cashCollectPaymentSuccess(millisecondsSinceCustomerIteractionStarted: Double) -> WooAnalyticsEvent { | ||
WooAnalyticsEvent(statName: .pointOfSaleCashCollectPaymentSuccess, properties: [ | ||
Key.millisecondsSinceCustomerInteractionStarted: "\(millisecondsSinceCustomerIteractionStarted)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically we could also track millisecondsSinceOrderCreationSuccess
but maybe it's not needed.
We track this property when the order is created or updated
#15148 needs to be reviewed first.
Closes: #15150
Closes: #15057
Changes
exit_menu_item_tapped
andexit_confirmed
to remove pos duplication on the event nameback_to_checkout_from_cash
view_docs_tapped
Description
Testing information
pos_interaction_with_customer_started
event:pos_back_to_checkout_from_cash:
...
menu, then on documentation, observepos_view_docs_tapped
eventpos_reader_ready_for_card_payment
event (no need to proceed with the payment). Observe it also has awaiting_time
property. This tracks the elapsed time between order creation and card readyness.pos_cash_collect_payment_success
. This has amilliseconds_since_customer_interaction_started
property since an item was added to the cart.RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: