Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Gen] Update Sourcery library to latest version #15216

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Feb 20, 2025

Closes: #15215

Description

Running rake generate for copiable and fakeable code generation throws errors in trunk.

This PR updates Sourcery to the latest version to fix this issue.

Steps to reproduce

  • Unit tests should pass.
  • Run rake generate from trunk and ensure that there are no errors.

Testing information

  • Ensured that rake generate works without errors.

Screenshots

NA


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@selanthiraiyan selanthiraiyan added this to the 21.8 milestone Feb 20, 2025
@selanthiraiyan selanthiraiyan added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Feb 20, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 20, 2025

1 Warning
⚠️ This PR is assigned to the milestone 21.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@selanthiraiyan selanthiraiyan marked this pull request as ready for review February 20, 2025 10:36
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 20, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15216-f504449
Version21.7
Bundle IDcom.automattic.alpha.woocommerce
Commitf504449
App Center BuildWooCommerce - Prototype Builds #13099
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@rachelmcr rachelmcr self-assigned this Feb 20, 2025
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for taking care of this update!

@selanthiraiyan selanthiraiyan merged commit ab20195 into trunk Feb 21, 2025
12 of 13 checks passed
@selanthiraiyan selanthiraiyan deleted the issue/15215-sourcery-update branch February 21, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code generation] rake generate not working in trunk
4 participants