Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15193 Set trailing internal padding on item row #15227

Merged

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Feb 20, 2025

Closes: #15193

Description

This ensures we always have internal trailing padding on cart items, whether they're shown in the checkout (with no remove button) or on the item list (with remove button)

We achieve this by moving the padding from the remove button, to the row itself.

Steps to reproduce

  1. Launch the app and go to POS
  2. Add items to the cart with various length names
  3. Change your dynamic type size
  4. Observe that theres always padding at the end of the item row
  5. Checkout
  6. Repeat steps 3 and 4

Testing information

Tested on an iPad Air running iOS 17.7.2

Screenshots

Before

before fixing padding

After

after fixing padding


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: bug A confirmed bug. feature: POS labels Feb 20, 2025
@joshheald joshheald added this to the 21.8 milestone Feb 20, 2025
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15227-84bfd4f
Version21.7
Bundle IDcom.automattic.alpha.woocommerce
Commit84bfd4f
App Center BuildWooCommerce - Prototype Builds #13090
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot wpmobilebot modified the milestones: 21.8, 21.9 Feb 21, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.8 has now entered code-freeze, so the milestone of this PR has been updated to 21.9.

@iamgabrielma iamgabrielma self-assigned this Feb 21, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Nice detail. LGMT!

@joshheald joshheald merged commit ad5525a into trunk Feb 21, 2025
23 of 26 checks passed
@joshheald joshheald deleted the issue/15193-horizontal-padding-on-cart-items-in-check-out branch February 21, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] There should be horizontal padding on cart item contents in checkout
3 participants